Skip to content

CASSGO-53 ObservedQuery.Consistency and ObservedBatch.Consistency fields #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

CASSGO-53 ObservedQuery.Consistency and ObservedBatch.Consistency fields #1862

wants to merge 1 commit into from

Conversation

@worryg0d
Copy link
Contributor

@worryg0d worryg0d commented Feb 10, 2025 •
edited
Loading

During retries, consistency of the query may be changed by retry policy implementations (e.g. DowngradingConsistencyRetryPolicy). To observe consistency changes new ObservedQuery.Consistency and ObservedBatch.Consistency fields were added.

Patch by Bohdan Siryk; Reviewed by <> for CASSGO-53

Closes #1798

@worryg0d
Added ObservedQuery.Consistency and ObservedBatch.Consistency fields
d217f0d 
During retries, consistency of the query may be changed by retry policy implementations (e.g. DowngradingConsistencyRetryPolicy).
To observe consistency changes new ObservedQuery.Consistency and ObservedBatch.Consistency fields were added.

Patch by Bohdan Siryk; Reviewed by <> for CASSGO-53
@joao-r-reis
Copy link
Contributor

joao-r-reis commented Feb 13, 2025

Hmm this probably has some overlap with #1447 , I'm going to prototype a bit and see if I can come up with a proposal for some potential API changes to resolve #1447 and these API changes will probably affect this issue/pr (#1862)

@worryg0d
Copy link
Contributor Author

worryg0d commented Feb 13, 2025

Ah, I see. We want to make Query immutable so changes to consistency won't be mirrored in Query and Batch, but in Iter. However, it shouldn't change this impl a lot

@worryg0d
Copy link
Contributor Author

worryg0d commented Feb 13, 2025

Some weird things are happening with CI again...

Installing script cli archive...
* Downloading...
curl: (22) The requested URL returned error: 503

'curl --fail --location --progress-bar "${SDKMAN_SERVICE}/broker/download/native/install/${SDKMAN_NATIVE_VERSION}/${SDKMAN_PLATFORM}" > "$sdkman_zip_file"': command failed with exit code 22.
Error: Process completed with exit code 22.

@jameshartig
Copy link
Contributor

jameshartig commented Jun 4, 2025

@joao-r-reis is this resolved now with #1868 since Query/Batch are now on the Observed structs?

@joao-r-reis
Copy link
Contributor

joao-r-reis commented Jun 5, 2025

@joao-r-reis is this resolved now with #1868 since Query/Batch are now on the Observed structs?

Yep, closing

@joao-r-reis joao-r-reis closed this Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Consistency for ObservedQuery

3 participants

@worryg0d @joao-r-reis @jameshartig